Repository navigation
Conversation
reese
force-pushed
the
reese-rust-comments
branch
from
November 10, 2026 03:51
aeea4b2 to
9209436
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the tin. This adds the
attach_commentsoption to the parse options and acommentsmethod on nodes that can return them, which is the same API used for #4255.I opted to fold both types of comments (the Vec of the entire file's comments + the attached comments from a node) into the
Commentsiterator, though I'd be fine to have a separateNodeCommentsiterator if that's preferred. As it stands though, I changedCommentsto store asource, one of which reads from the stored Vec and the other which usespm_node_commentto lazily read them.